Fix conditional check "Theme File Editor" menu #37616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #37592.
It looks like I messed up something when doing initial tests and was getting incorrect results πββοΈ
The
_add_plugin_file_editor_to_tools
isn't available when we're performing the check, so we still end up with two "Theme File Editor" sub-menu items.Cord now uses
wp_list_users
for version check. We're using this function for similar checks in a few other places, so it should be safe.Props to @costdev for discovering the issue π₯
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).