Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Duplicated "Theme File Editor" menu #37592

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

Mamaduka
Copy link
Member

Description

PR adds a conditional check before moving "Theme Editor" under the "Tools", to avoid duplicated sub-menu items in WP 5.9.

Closes #37568.

How has this been tested?

  1. Running WP 5.9 beta 4
  2. Go to the Dashboard and click on the "Tools" menu
  3. It should only display single "Theme File Editor" sub-menu item.

Screenshots

Before After
CleanShot 2021-12-22 at 19 14 51 CleanShot 2021-12-22 at 19 15 07

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Dec 22, 2021
@Mamaduka Mamaduka added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Dec 22, 2021
@Mamaduka Mamaduka requested review from gziolo and carolinan December 22, 2021 15:21
@Mamaduka
Copy link
Member Author

Thank you, @aristath!

@Mamaduka Mamaduka merged commit 668fde4 into trunk Dec 23, 2021
@Mamaduka Mamaduka deleted the fix/duplicated-theme-editor-menu branch December 23, 2021 14:49
@github-actions github-actions bot added this to the Gutenberg 12.3 milestone Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate "Theme Editor" menu in Tools as 5.9 relocates and renames the menu item
2 participants