Navigation Block: Revert all margins on navigation-item in editor #37587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Bug
|
Size Change: -24 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
mikachan
changed the title
jasmussen
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the top and bottom margins for each
navigation-itemin the editor.The left and right margins are already being reverted to allow this block to work with classic theme auto margins. However, in a theme that doesn't support theme.json, when a background is applied to the
navigationblock, the default vertical margins from the 'Edit Post' classic stylesheet create too much spacing in the editor, compared to what is output on the front end.These are the styles from the Edit Post classic stylesheet that these changes override:
How has this been tested?
This bug was originally found when working on an issue in the Seedlet theme: Automattic/themes#3684
It can also be tested by activating any other theme that does not support theme.json, and then:
There should be larger (or different) vertical margins on the navigation block in the editor compared to the front end.
Screenshots
These are from testing with Seedlet.
Without this PR:
With this PR:
Types of changes
Enhancement / bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).