Seedlet: Fix navigation block styles in editor #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
reviewed
Dec 20, 2021
| @@ -16,23 +20,33 @@ | |||
| } | |||
| } | |||
|
|
|||
| .wp-block-navigation-item { | |||
| > a { | |||
| border: 0; | |||
There was a problem hiding this comment.
Is this going to play nicely with #5195 ?
There was a problem hiding this comment.
Hmm.. possibly, although it looks like the navigation may need to override the text-decoration styles instead of the border.
|
This works in my testing, but I'm not that keen on adding the extra CSS. What happens if we leave it out? |
|
If I remove the extra CSS it looks pretty different to the frontend: I wonder if we can fix this in the block? |
Ah yeah, I was thinking this was very Seedlet-specific. I'll try playing around with the block now! |
|
Opened a GB PR to hopefully fix the spacing issue here: WordPress/gutenberg#37587 |
scruffian
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR removes some background and margin properties from the navigation container in the editor for Seedlet. This fixes a bug where the navigation block looks different between the front end and the editor when a background is applied to the block.
It also fixes the following:
Before:
After:
Related issue(s):
Fixes #3684