Add create new menu button to nav block #36245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
|
Size Change: -961 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Nov 5, 2021
|
Nitpick: The button looks like a "submit" to me, as if I was doing something with all the listed menu items. A CSS change to make it look more like another option would be nice. Other than that, it looks good! |
Yeah, I see what you mean 🤔 |
|
@adamziel I pushed a much simpler version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the navigation block, users could switch between menus, but within an individual block it was difficult to create an entirely new menu.
A user would have to remove the block and add a new one. This adds a convenient button to return to the placeholder:
As highlighted in this comment, this will be important in a navigation area - #36210 (comment).
How has this been tested?
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).