Show the placeholder again when moving from a valid menu to non-existing menu #36210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Block] Navigation
|
Size Change: +4 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
Merged
|
One thing @adamziel that I noticed while testing is that:
It is very confusing. |
|
Also tested that it doesn't break any other aspect of the block, like pattern insertion
Yeah, this is a missing feature. I think we need a 'Create new' option in the Select menu dropdown. I'll see if I can smash it out quickly. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the navigation block only displays the placeholder after it's been initially mounted. If the
navigationMenuIdis later updated to0, the block is stuck in a "forever loading" state. This PR makes the block react to an empty menu and display the placeholder again.Test plan: