-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing titles in general areas #35657
Conversation
Size Change: -4.67 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
I'd love to hear more thoughts on whether we should surface general template parts at this stage. Either way, we should use the latest Template Part icon rather than the Layout icon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm and the bug is fixed when I test locally! 👍
I'll approve preemptively but we should change the icon as @jameskoster says.
The only downside I see is that it's more likely that you would have multiple General template parts and so it's not clear where pressing General will take you. This isn't a problem with Header and Footer where there is usually only one of each. |
Description
Fix #35587.
Fix missing titles in general areas in template areas. I guess we'd want to fix this first or at least before we've decided the answer of "do we want to surface general template parts in the Areas UI?" in the original issue.
How has this been tested?
Follow the reproduction steps in the original issue.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).