Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a template part in isolation the Areas UI is surfacing general template parts #35587

Closed
jameskoster opened this issue Oct 13, 2021 · 1 comment · Fixed by #35657
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Oct 13, 2021

Description

In my Footer template part I have a general template part for copyright details:

Screenshot 2021-10-13 at 12 08 16

As you can see in the screenshot, both in the template details popover and the Inspector, there's an empty button representing this nested template part.

This raises a question – do we want to surface general template parts in the Areas UI?

We do not currently do this when editing a parent template. So for now it may be simplest to do that same when editing template parts in isolation.

Step-by-step reproduction instructions

  1. Add a general template part inside a header or footer template part
  2. Edit that header or footer template part in isolation
  3. Observe the empty button in the "Areas" UI that represents the general template part
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Oct 13, 2021
@jameskoster
Copy link
Contributor Author

Related:

If you edit a template that includes no header or footer template part areas, you also see the strange blank buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants