Add more options to template areas in template details #35577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Template Editing Mode
kevin940726
requested review from
adamziel,
getdave,
noisysocks,
talldan,
jameskoster,
tellthemachines and
anton-vlasenko
|
Size Change: +219 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/template-areas-more-option
branch
from
67c7343 to
983fc1e
Compare
jameskoster
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Love it. I did notice a bug with the areas section in the Inspector, but I'll open a separate issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #29687.
Add more menu dropdown to each of the template area in template details. Currently only Edit template button and Clear customizations button are implemented in the dropdown.
I'm not sure whether the Discard unsaved changes button is possible to implement though. Either way, better to leave it to another PR.
The more menu icon is positioned absolutely, so it can be navigated using natural tab orders. Not sure if it's the best solution though, open to other ideas!
How has this been tested?
tt1-blocksthemeScreenshots
Kapture.2021-10-13.at.12.45.56.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).