Saving post: transparent disabled button. #35542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mtias
approved these changes
Oct 12, 2021
|
Size Change: +25 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
fix/save-state-saving
branch
from
f3355d6 to
4c38526
Compare
|
Both the "Save draft" and "Preview" buttons have grey backgrounds when disabled. You can see it easier by creating a new post without typing or saving. |
|
Yes, a separate refactor tweaked those button, that was part of what caused the initial issue with the "Saved" message. For the time being I've intentionally not touched those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #34947 (comment).
The save state indicator is a disabled button, but has a gray background as shown in the comment above. This PR makes the background transparent. It's a big hard to capture a screenshot of, but it's the brief moment when the document is being saved.
It's important to note that in both the saving and saved states, the button is inert, but it still serves as a an indicator of the save state, as well as what's going on. So it's important that it's legible in this state.
How has this been tested?
Write content, then save, and the save button should have a transparent background even when saving.
Checklist:
*.native.jsfiles for terms that need renaming or removal).