Fix save-state indicator appearance. #34947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
jasmussen
force-pushed
the
fix/save-state-indicator
branch
from
04c4c25 to
3af7a00
Compare
|
Size Change: +46 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
7 tasks
ellatrix
approved these changes
Sep 20, 2021
|
Thank you!
It's definitely appropriate for disabled buttons. In this case, it was important that the saved state indicator was legible. |
|
Let's also remove it from the "is saving" state:
|
7 tasks
|
Created fix in #35542 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent refactor of the save state made it a disabled button rather than just text, causing it to have a gray background:
This PR fixes that:
Checklist:
*.native.jsfiles for terms that need renaming or removal).