Update getTermsInfo() to workaround parsing issue for translatable strings #33341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
swissspidy
approved these changes
Jul 10, 2021
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 12, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See wp-cli/i18n-command#255.
This is a (temporary) workaround for an issue in the PHP library Peast which is used by WP-CLI make-pot to extract translatable strings in JavaScript files. The same command is used on w.org to extract the strings from WordPress core which are then imported to translate.w.org.
block-library.jsis currently the only affected file by this issue thus this PR was created to ensure the missing strings will be available for WordPress 5.8 while waiting for an upstream fix.This is the new output:
How has this been tested?
getTermsInfo()frompackages/block-library/build/query/utils.jsand replace it with the currentgetTermsInfo()from step 1Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).