-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations cache can't be refreshed due to missing strings from Gutenberg GlotPress #33364
Comments
Since all these strings are from the block-library package, I think this is a duplicate of wp-cli/i18n-command#255 See also #33341 cc @ocean90 |
Thanks for pointing out the issue references and for the quick response 🙇 ! Yeah, after checking the issue you pointed, I agree that looks like a duplicate. |
Can we close this ticket @fluiddot, especially now that the duplicate-of is closed? Or is there some more context captured in this one? |
I would keep it open because although the duplicate-of is closed, until the Gutenberg GlotPress project gets updated with the missing strings, the translations cache in GB-mobile can't be refreshed. |
Since WordPress.org was already patched to include that fix, I assume this should be resolved once GB 11.1 is released on the plugin directory. |
Ok, in that case, I think we can close the issue as it will eventually be fixed with the GB 11.1 release. The GB 11.1 milestone's due date is July 14, 2021 so it won't take too long until is updated 🎊 . Thank you so much @swissspidy for the help on this issue 🙇 ! |
Description
On the mobile version, we cached the translations files downloaded from GlotPress in the Gutenberg-Mobile repo, the purpose is to avoid the issue described here where critical strings were not included, therefore we use the cached version that contains them and since then we have used it when cutting new releases.
Recently, as I saw that the original issue was fixed, I proceed to refresh the cache, however, I noticed that we still lack a high number of translations.
New and removed strings between versions
Here you can see the new and removed strings between the cached version (created for version GB-mobile
1.52.2
) and current one downloaded from GlotPress:New strings (247)
Removed strings (805)⚠️
As you can observe, there're 805 strings that have been removed between both versions, I understand that some of them are actual strings that are no longer used, but I checked a couple of them and I see that are referenced in the code:
Example 1
String:
Spacer settings
Referenced in:
block-library/src/spacer/edit.js:161
gutenberg/packages/block-library/src/spacer/edit.js
Line 161 in b29e3eb
Included in Gutenberg GlotPress project: No
Example 2
String:
Write verse…
Referenced in:
block-library/src/verse/edit.js:53
gutenberg/packages/block-library/src/verse/edit.js
Line 53 in b29e3eb
Included in Gutenberg GlotPress project: No
I'm not sure what's causing this issue but probably we have another problem when parsing the code files and generating the localization strings files.
Step-by-step reproduction instructions
N/A
Expected behaviour
Strings referenced in the code should be present in the translations files.
Actual behaviour
Some strings referenced in the code are not present in the translations files.
Screenshots or screen recording (optional)
N/A
WordPress information
Device information
The text was updated successfully, but these errors were encountered: