Remove usages of withState from edit-post and editor #32349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I also noticed that a lot of examples in docs use |
jsnajdr
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
Yes. I tried to update a few |
jsnajdr
force-pushed
the
remove/with-state-usages
branch
from
ae49f48 to
aaf3bfd
Compare
|
Size Change: -45 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Thanks for the PR. Worth noting that this HoC preceded React hooks :), funny how the API was very close. We could potentially consider adding a deprecation message there. |
|
I think deprecation got mentioned in another PR - #32326. |
7 tasks
|
Created PR for deprecation #32368. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usages of the
withStateHOC from three places that still use it. It's very easy to replace the HOC with theuseStatehook. Kind of demonstrates how antiquatedwithStateis today.After this patch,
withStateis used only inREADME.mdexamples and in Storybook stories. No production code.