compose: Type withState as any
#32326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: +5 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
That's a great idea. The |
sarayourfriend
force-pushed
the
add/types-compose-with-state
branch
from
79f798e to
112ff78
Compare
sarayourfriend
changed the title
withState in a naïve waywithState as any
sarayourfriend
force-pushed
the
add/types-compose-with-state
branch
from
de7c74d to
63f706d
Compare
ciampo
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm fairly certain these types are incorrect. We just need something that works even if we throw
@ts-ignoreall over the place or, worst case, type the return type asany.I've proposed deprecating this function in the weekly core-js meeting.
Part of #18838
How has this been tested?
It's really not.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).