Widgets: Add Welcome Guide #31925
Merged
Widgets: Add Welcome Guide #31925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
the
[Feature] Widgets Screen
noisysocks
commented
May 18, 2021
noisysocks
force-pushed
the
add/widgets-welcome-guide
branch
from
1d2f9e1 to
b9ff22a
Compare
noisysocks
changed the base branch from
trunk
to
add/widgets-editor-settings-menu
noisysocks
requested review from
adamziel,
draganescu,
kevin940726,
talldan and
tellthemachines
as code owners
talldan
force-pushed
the
add/widgets-editor-settings-menu
branch
from
4276707 to
c8e3476
Compare
|
Size Change: +278 kB (+21%) 🚨 Total Size: 1.58 MB
ℹ️ View Unchanged
|
talldan
force-pushed
the
add/widgets-welcome-guide
branch
from
b9ff22a to
aaa1f9f
Compare
talldan
approved these changes
May 19, 2021
This really highlights how |
18 tasks
7 tasks
noisysocks
force-pushed
the
add/widgets-welcome-guide
branch
from
aaa1f9f to
e3615f0
Compare
|
Why was this merged with failing tests? It's not because trunk is failing that that's ok? |
|
Testing. WordPress 5.7.2. Theme: Twenty Twenty. This is what I see: Welcome-Guide-Widget-screen.mp4Thank you for adding this feature! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires #31926.
Implements part of #30887.
Adds
WelcomeGuideto the widgets screen. This is mostly copied fromWelcomeGuideinedit-post.We show the "new user" copy when all widgets are block widgets, because when this feature is merged to Core, we will update
wp_install_defaults(here) to set up a sidebar containing block widgets in new WordPress installations. We can't do this in the Gutenberg plugin, though.How has this been tested?
localStorage.clear().Screenshots
Checklist:
*.native.jsfiles for terms that need renaming or removal).