E2E Tests: Run tests against WP 5.9 RC1

[spacedmonkey]

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

• This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

• This PR addresses an existing issue and I have linked this PR to it in ZenHub
• I have tested this code to the best of my abilities
• I have verified accessibility to the best of my abilities (docs)
• I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
• This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
• I have added documentation where necessary
• I have added a matching Type: XYZ label to the PR

---

Fixes #

[swissspidy]

@spacedmonkey Tests against RC 1 are failing now because of this change in core: https://core.trac.wordpress.org/ticket/54181

In trashAllTerms(), #bulk-action-selector-top is used, which in WP 5.9+ won't be displayed anymore if there are no terms.

So we need to make it a bit more robust.

[swissspidy]

The Web Stories Widget Block e2e test fails because the Twenty-Twenty Two theme does not support widgets.

We might want to consider installing/activating Twenty Twenty-One by default in bin/local-env/install-wordpress.sh and then have dedicated E2E tests for block-based themes.

[spacedmonkey]

The Web Stories Widget Block e2e test fails because the Twenty-Twenty Two theme does not support widgets.

How is that possible, we are using 2020 for e2e test ain't we?

[swissspidy]

Ah, you're right. Then I suppose some selectors have simple changed.

.block-editor-inserter__search-input no longer exists.

Maybe .block-editor-inserter__search input works.

[swissspidy]

I am converting this to a draft simply to avoid generating unnecessary Percy snapshots while this is WIP.

[swissspidy]

Is the version check really needed? Didn't it work the way you had it before, by checking whether the functions exist?

[spacedmonkey]

Sadly it didn't work the way I had it before. See https://github.com/google/web-stories-wp/runs/4728644759?check_suite_focus=true#step:11:11

[spacedmonkey]

I would love another way around doing this check.

[swissspidy]

Hmm sounds like all that is needed is some conditional check, perhaps easiest with optional chaining (?.) ,to avoid the isFeatureActive is not a function error.

// Disable welcome guide if it is enabled.

// The former selector is for WP < 5.9
const isWelcomeGuideActive = await page.evaluate(() => {
  return wp.data.select('core/edit-widgets')?.__unstableIsFeatureActive?.('welcomeGuide') ||
  wp.data.select( 'core/interface' )?.isFeatureActive?.( 'core/edit-widgets', 'welcomeGuide' );
});

if (isWelcomeGuideActive) {
  // The former action is for WP < 5.9
  await page.evaluate(() => {
    wp.data.dispatch('core/edit-widgets')?.__unstableToggleFeature?.('welcomeGuide');
    wp.data.dispatch( 'core/interface' )?.toggleFeature?.( 'core/edit-widgets', 'welcomeGuide' );
  });
}