Fix submenu direction justification regression #31414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Regression
|
Size Change: +26 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
May 4, 2021
|
Thank you! I'll land this one.
Yes, good point. I have something working here: #29771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #30342, it was made so that submenus open in the opposite direction of the justification, i.e. if your navigation menu is right justified, submenus open leftwards.
That regressed in some of the recent refactors. This PR restores it:
How has this been tested?
Insert a navigation menu with submenu items. Ideally we test both manual menu items and page list generated submenu items.
Justify right, and test that nested submenus open leftwards.
Bonus points, test space between, and ensure the right-most menu item has nested submenus. Then test that and verify it opens leftwards as well.
Checklist:
*.native.jsfiles for terms that need renaming or removal).