Try: Allow space between on page list. #29771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
"Display contents" has reasonable support and can be seen as a progressive enhancement for this particular edgecase: https://caniuse.com/css-display-contents |
|
Size Change: +321 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
vcanales
reviewed
Mar 12, 2021
There was a problem hiding this comment.
It works perfectly in the frontend, but in the editor I'm seeing the page items stack up vertically when I set justification to space between.
justification1.mov
The video is from Firefox, but I see the same behavior using Chrome.
Not sure how helpful this might be, but in the editor, after removing the display: contents rule, the component starts doing this dance:
justification2.mov
I tested T19 and TT1.
mkaz
force-pushed
the
try/fix-page-list-justification
branch
from
9f4d4bf to
2e44c07
Compare
vcanales
reviewed
Mar 13, 2021
jasmussen
force-pushed
the
try/fix-page-list-justification
branch
from
2e44c07 to
ee89990
Compare
|
That does work better, Vicente. However I'm not super comfortable with the use of |
jasmussen
added
Needs Technical Feedback
scruffian
force-pushed
the
try/fix-page-list-justification
branch
from
a317afc to
d211e1e
Compare
|
IMO this is an improvement, but we should also look into removing the margins when space-between is selected so that they alignment is even: |
jasmussen
force-pushed
the
try/fix-page-list-justification
branch
from
f29a23f to
7c4ee78
Compare
|
Thank you @scruffian, I'm happy to try this, even though the
Agreed. I pushed a fix for that in #30287, which touches other margins and therefore felt a better place to me:
|
|
Is there still value in landing this one? |
scruffian
force-pushed
the
try/fix-page-list-justification
branch
from
7c4ee78 to
596ff58
Compare
|
Yes, it looks ready to land to me |
|
Checking in on this one @vcanales @scruffian @jasmussen, was this one still needed / what else needs to be done for landing? Another review? |
|
Thanks for the check-in, Kerry. After Ben's last sanity check, I think this is ready for a final review. My only concern was and to an extent the use of |
7 tasks
Co-authored-by: Vicente Canales <[email protected]>
jasmussen
force-pushed
the
try/fix-page-list-justification
branch
from
596ff58 to
dfa8d06
Compare
getdave
approved these changes
May 17, 2021
|
Thanks so much 💫 |
carolinan
approved these changes
May 17, 2021
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29767.
The page list block, by virtue of being an additional container, did not work with the "space between" justification.
This PR improves the situation in the editor, though the preview isn't perfect when using a mix of page list and other items, and make it perfect on the frontend.
Editor before:
Frontend before:
Editor after:
Frontend after:
How has this been tested?
Please test a page list block with some other menu items in a navigation block. Test all justifications.
Be sure to deselect the navigation block after choosing a justification.
Checklist: