Only split block styles loading for block themes #31309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Bug
|
Size Change: -297 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
By looking at #31293 it seems the issue is that the block styles are rendered in different places. Can we make it so they are always rendered in the same place (in the header)? I'm not sure where things such as I presume these come from core. My concern with enqueuing core styles in the footer (both these block styles + global styles) is that it's more difficult for 3rd parties to override them (themes, plugins, etc) should they need it. |
|
Pushed an alternative fix that makes more sense for non-FSE themes 👍 |
+1 to this, I was confused why sometimes those inline styles would be loaded in the footer vs always the header, and could not figure out where they were coming from. |
aristath
changed the title
7 tasks
youknowriad
pushed a commit
that referenced
this pull request
Apr 30, 2021
* Load global styles in the footer if theme is not a block theme * We don't really need the current_theme_supports check here 🤔 * The better fix
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the theme is using
theme.json- so has global styles enabled, but is NOT a block theme, global styles get overridden by other styles.See #31293 for a detailed description of the issue.
This PR fixes the issue by making sure that separate styles are only used in FSE themes - or when the theme opts in.
How has this been tested?
Followed the instructions in #31293 and confirmed this fixes the issue.
Checklist:
*.native.jsfiles for terms that need renaming or removal).