Quadrat: styles are being overridden by Gutenberg

[jffng]

Gutenberg's default block styles are overriding BCB's, for example in the button:

This started after #3667

[MaggieCabrera]

This looks like a GB issue:

Block-based template	PHP template

When the template is a FSE template the default styles for the button are loaded inline before the styles that come from theme.json. When the template is a php one, the default button styles are loaded from a stylesheet (plugins/gutenberg/build/block-library/blocks/button/style.css) and loaded before what's coming from theme.json.

[jffng]

Thanks @MaggieCabrera that helps, I dug into this further. The styles loading in the wrong order seems to be specific to the locate_template filter we introduced, not that it's a php template nor a child theme of a block theme.

I tried to recreate the bug unsuccessfully by doing the following:

• Activate emptytheme
• Add an index.php which loads the index.html (renamed to something else like block-based-index.html as to not trigger FSE) via do_blocks
• Add a style via theme.json for example { styles.core/button.color.background: red }

The styles load in the correct order, even though it's a php template:

I can fix this issue by adding remove_theme_support( 'block-templates' ). The downside of doing this is that it disables the ability to add new templates introduced in WordPress/gutenberg#30438

Some related Gutenberg code:

• Load separate block assets: https://github.com/WordPress/gutenberg/blob/7c134eb66f1e5ed67db646e19234d9edf6e3090e/lib/compat.php#L11-L26
• gutenberg_supports_block_templates can determine whether the block assets should be loaded separately https://github.com/WordPress/gutenberg/blob/7c134eb66f1e5ed67db646e19234d9edf6e3090e/lib/full-site-editing/full-site-editing.php#L23
• add_theme_support( 'block-templates' ) is true by default: https://github.com/WordPress/gutenberg/blob/7c134eb66f1e5ed67db646e19234d9edf6e3090e/lib/init.php#L180

[MaggieCabrera]

This would be solved by fixing the template inheritance in GB. I will try and look into it as well, see if we can solve it there.

[jffng]

@MaggieCabrera opened a fix in Gutenberg WordPress/gutenberg#31123

[jffng]

Closed by WordPress/gutenberg#31309