Site Editor: Fix empty content when creating a new template #28882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Type] Bug
Copons
requested review from
mattwiebe,
youknowriad,
vindl,
david-szabo97,
jeyip,
noahtallen,
epiqueras and
Addison-Stavlo
Copons
commented
Feb 9, 2021
| @@ -50,7 +50,7 @@ export default function NewTemplateDropdown() { | |||
| excerpt: description, | |||
| // Slugs need to be strings, so this is for template `404` | |||
| slug: slug.toString(), | |||
| status: 'draft', | |||
| status: 'publish', | |||
There was a problem hiding this comment.
This change is not related to the fix, but it was something I've tried changing when investigating.
Thing is, templates are always created as publish, so using draft here would only be confusing.
There are other mentions of draft templates in the Navigation sidebar (e.g. drafts items would have a [Draft] label prepended to the title.
I haven't cleaned them up for now, as I don't think they'd be as confusing as this.
|
Size Change: +55 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
david-szabo97
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#28229 surfaced a bug with the new template creation in the Site Editor (accessible from Navigation -> Templates ->
+button).The new template gets created correctly, added to the Redux state, and saved in the database.
Although, it should also inherit the content from the closest more generic template available (e.g. creating
front-pagewould inherithomeif it exists, orindexotherwise).The new template gets the correct content (it's there in both state and DB), but not in the editor.
Reloading the editor would make it show up; as it would opening the template alone in a Post Editor.
All the various contexts look good to me too.
The only issue I've noticed is that the
addTemplateaction (which internally usessaveEntityRecordto create the template, andsetTemplateto switch the editor to the new template) doesn't create a new item in'core'.root.entities.data.postType.wp_template.editsfor the new template, which is what the editor provider uses to populate the editor with blocks.This PR adds an
editEntityRecorddispatch, adding the new template's parsed content to theedits.How has this been tested?
+button, and add a new template.indextemplate).Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: