FSE Navigation sidebar: Show single post template in posts templates #28229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
requested review from
mattwiebe,
jameskoster,
vindl,
Copons,
jeyip,
noahtallen and
Addison-Stavlo
|
Size Change: +1 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jameskoster
requested changes
Jan 15, 2021
|
If we have a default for
I can't find the issue now but we discussed also moving the The reasoning behind for this suggestion is that the We don't have to do it in this PR though :) FWIW |
Addison-Stavlo
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Tested and this works as advertised. This looks consistent to me 👍 - I think its more up to you whether we want to re-arrange what shows up where here or in a follow up.
FWIW single should certainly not be in the "Posts" section, since that template can also resolve for pages.
The description for single says: "Used when a single entry that is not a page is queried" - so it doesn't seem to be intended for pages. Maybe we are confusing it with the general template "singular"?
You're correct. |
You are not alone. 🤣 I didn't remember the difference either until i went looking for it and saw the description. |
|
For the record, this is why I would advocate not offering these templates as options in the (+) menu at all. They're difficult to understand, and probably best left for themers to use at their discretion. "Page" (
|
They do at least have the accurate description there though. It does enable a good flow for those themers. I would suspect most non themers would rather get a theme that supplies these templates than create them themselves or wouldn't need to use this "+" flow option. But even in the case they do the descriptions should definitely help guide them. |
I think the existing setup should handle this situation and fall back to the more generic template that handles the rendering of |
vindl
approved these changes
Jan 27, 2021
david-szabo97
force-pushed
the
add/navigation-panel-posts-show-single-post
branch
from
ed46ec2 to
35547a3
Compare
jameskoster
approved these changes
Feb 4, 2021
david-szabo97
force-pushed
the
add/navigation-panel-posts-show-single-post
branch
from
35547a3 to
6f25b59
Compare
|
So, it seems there is an unrelated issue on template creation: the template is created correctly, with the correct fallback content (retrieved with this function — we might want to add a I'm looking into it. 👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show
single-posttemplate in the posts menu.How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: