blocks package: Replace hardcoded store names #28789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Code Quality
|
Size Change: +33 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Well, this doesn't work 😄 I guess it's related to circular reference. gutenberg/packages/core-data/package.json Line 31 in 8d61b88 |
|
Right, this refactor helps to catch some fundamental issues with the code that were hidden. The only question now is what should depend on what 😅 @youknowriad and @mcsf, something to think about once you find the time. My guess is that |
|
OK, I'm trying to fix the root issue by moving the logic for template parts to the block implementation. |
youknowriad
reviewed
Feb 8, 2021
| @@ -144,7 +145,7 @@ export function getBlockLabel( blockType, attributes, context = 'visual' ) { | |||
| // Attempt to find entity title if block is a template part. | |||
| // Require slug to request, otherwise entity is uncreated and will throw 404. | |||
| if ( 'core/template-part' === blockType.name && attributes.slug ) { | |||
| const entity = select( 'core' ).getEntityRecord( | |||
| const entity = select( coreStore ).getEntityRecord( | |||
There was a problem hiding this comment.
Yep, this should definitely be moved to the block itself :) I think we have a function for that right?
There was a problem hiding this comment.
Yes, I'm on it. I found the PR where it was introduced: #28330. It only confirms that it should be moved.
6 tasks
|
Replaced with #28828. Let's continue there, thanks @david-szabo97 for raising this issue 💯 |
gziolo
deleted the
update/blocks-package-replace-hardcoded-store-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #27088
Replace hardcoded store names with their store object.
How has this been tested?
Make sure tests are passing. Smoke test.
Types of changes
Code Quality
Checklist: