Template Part - fix labels shown - use title instead of slug #28330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
added
[Type] Bug
Addison-Stavlo
requested review from
mattwiebe,
vindl,
Copons,
david-szabo97,
jeyip and
noahtallen
Addison-Stavlo
changed the title
|
Size Change: +636 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Addison-Stavlo
force-pushed
the
fix/template-part-titles-in-interface
branch
from
aba2479 to
c650d48
Compare
david-szabo97
approved these changes
Jan 19, 2021
|
Note that this will resolve #28302 by not showing the slugs in user-facing UI. |
aristath
approved these changes
Jan 20, 2021
vindl
approved these changes
Jan 20, 2021
gziolo
reviewed
Feb 8, 2021
| @@ -140,6 +141,19 @@ export function normalizeBlockType( blockTypeOrName ) { | |||
| * @return {string} The block label. | |||
| */ | |||
| export function getBlockLabel( blockType, attributes, context = 'visual' ) { | |||
| // Attempt to find entity title if block is a template part. | |||
| // Require slug to request, otherwise entity is uncreated and will throw 404. | |||
| if ( 'core/template-part' === blockType.name && attributes.slug ) { | |||
There was a problem hiding this comment.
This logic should be added as __experimentalLabel in the registerBlockType call for the Template Part block.
There was a problem hiding this comment.
Oh, that makes more sense. Thank you for fixing this!
This was referenced Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With recent changes to template parts, slugs no longer update along with the title while slug is still used in the interface as a label to show users. This updates some labels shown in the interface to show the title instead of the slug.
Before
Previously - the label in both the sidebar and the selector would show the slug
template-part-*instead of the user defined title:the notification shown on inserting template parts was not showing any proper label:
And the label in document actions in the top toolbar was based on the slug:
After
After this change - the sidebar and selector should display the proper labels for the template parts:
the notification should be fixed:
and the label in the top toolbar should be based on the title as well:
How has this been tested?
Screenshots
Types of changes
Checklist: