Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests Workflow: Enable for documentation-only PRs #28696

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Unit Tests Workflow: Enable for documentation-only PRs #28696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c683fd1
Unit Tests Workflow: Enable for documentation-only PRs
ockham Feb 3, 2021
93fc82a
Remove 'now' from comment
ockham Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
name: Unit Tests

# Since Unit Tests are required to pass for each PR,
# we cannot disable them for documentation-only changes.
on:
pull_request:
paths-ignore:
- '**.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explore ways to allow this kind of config using if statements in the jobs. I think some reusable github actions already exist for this use-case.

It's also very useful if we decide one day to consolidate in a single workflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #28669 for an exploration and some discussion 🙂

push:
branches: [master, wp-trunk]
paths-ignore:
- '**.md'

jobs:
unit-js:
Expand Down