Unit Tests Workflow: Enable for documentation-only PRs #28696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
[Type] Automated Testing
|
Size Change: +1.38 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
I think it was @mkaz who added those checks: while this is fine by me, I'm also a newbie when it comes to GitHub actions so I was hoping to get him interested in reviewing this PR. |
noisysocks
approved these changes
Feb 4, 2021
Good point, thanks! I'll make that change and 🚢 |
youknowriad
reviewed
Feb 8, 2021
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - '**.md' |
There was a problem hiding this comment.
I think we should explore ways to allow this kind of config using if statements in the jobs. I think some reusable github actions already exist for this use-case.
It's also very useful if we decide one day to consolidate in a single workflow.
There was a problem hiding this comment.
See #28669 for an exploration and some discussion 🙂
desrosj
pushed a commit
that referenced
this pull request
Jul 2, 2021
(cherry picked from commit 8cfbfb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently made the PHP and JS unit tests required -- meaning they have to pass before a PR can be merged.
(This is in the wake of a recent issue that left PHP unit tests in a broken state -- also for subsequent PRs.)
@nosolosw then discovered that this affected documentation-only PRs (such as #28639): Since the unit test workflow had a condition that exempted it from running on such PRs, it never passed -- and the 'required' check criterion was never fulfilled.
This PR removes that condition from the workflow (so that the unit tests workflow always runs).
I was originally trying in #28669 to be smart and enable the workflow, but keep skipping unit tests for documentation-only PRs. Unfortunately, this has turned out harder than expected (see this comment).
(Given the choice between saving some time by not running them on doc fixes, and making them mandatory for all PRs, I have a clear preference for the latter.)