E2E tests: Handle upgrade screen #28592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Automated Testing
david-szabo97
requested review from
ockham,
mcsf,
mattwiebe,
gziolo,
vindl,
Copons,
jeyip and
Addison-Stavlo
david-szabo97
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
There are e2e failures, but I believe that they're unrelated (and should be fixed by #28638). I'll rebase this PR now. |
jeyip
force-pushed
the
fix/e2e-stuck-on-upgrade-screen
branch
from
aad4555 to
bd77454
Compare
|
Hmmm...the e2e tests with Here's an example of the URL we're visiting: And here's a screenshot: I've confirmed that the selector we're using to click on the update button exists. |
|
@jeyip Silly question, did you run |
I didn't! Lemme give that a shot after I get back from lunch 👍 Just to be safe, I'll destroy and rebuild the current WordPress docker instance as well. |
|
Blowing everything away and re-rerunning specs fixes the issue |
jeyip
approved these changes
Feb 1, 2021
vindl
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E2E tests might get stuck on the "Database Update Required" screen. This PR takes care of the screen by automatically clicking on update.
How has this been tested?
The quickest way is to change the
db_versionoption in the database.at
gutenberg/gutenberg.php
Lines 17 to 19 in cdc34fb
npm run test-e2e -- --puppeteer-interactive)Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: