Site Editor: Add e2e tests for templates export #28324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
force-pushed
the
add/site-editor-export-e2e-tests
branch
from
07f7f0f to
9019132
Compare
|
Size Change: -101 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
david-szabo97
added
[Feature] Full Site Editing
[Type] Automated Testing
david-szabo97
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
david-szabo97
requested review from
noahtallen,
vindl,
jeyip,
mattwiebe,
Addison-Stavlo and
Copons
There was a problem hiding this comment.
This looks good and the test is passing for me locally! A couple small Qs - also maybe @youknowriad may have some input here since he has worked with the export stuff a bit more.
| @@ -100,3 +100,33 @@ export const navigationPanel = { | |||
| await item.click(); | |||
| }, | |||
| }; | |||
|
|
|||
| export const siteEditor = { | |||
There was a problem hiding this comment.
Nice! This was a bit overdue and is good to see. 😁
There was a problem hiding this comment.
When things become more stable (and core merge approaches), we could start extracting some of these to e2e-test-utills.
youknowriad
reviewed
Jan 20, 2021
| } | ||
| } | ||
|
|
||
| function delay( time ) { |
There was a problem hiding this comment.
This is just a duplication of page.waitFor it seems.
There was a problem hiding this comment.
page.waitFor is deprecated, so I'd rather avoid introducing it in new tests. I'm thinking about replacing delay with page.waitForTimeout.
There was a problem hiding this comment.
We may have to update our waitFor lint rule to also target the usage of waitForTimeout
youknowriad
reviewed
Jan 20, 2021
Addison-Stavlo
approved these changes
Jan 20, 2021
vindl
reviewed
Jan 26, 2021
There was a problem hiding this comment.
I tried running these test locally but they are failing for me for some reason on: TimeoutError: waiting for selector .edit-site-visual-editor iframe failed: timeout 30000ms exceeded.
I rerun the tests on the PR in CircleCI to double-check and it's still passing here, so I'm assuming something is messed up with my local setup. But now some seemingly unrelated e2e tests have failed here. :[
david-szabo97
force-pushed
the
add/site-editor-export-e2e-tests
branch
from
5e0b59d to
6cfee3b
Compare
|
Did a rebase, hopefully fixing CI tests. It works fine locally. I usually run |
Curiously enough, I'm getting the same error lately whenever I try to run the e2e tests locally (while they do work in CI) -- most recently for #28554.
Maybe it's my Linux box -- tho AFAIK you're on macOS @vindl, right? Anyway, let's keep in touch in case either of us finds a solution to this. |
|
I think I tracked it down by running e2e tests in interactive mode: Turns out e2e tests are stuck at a (pre-login) "Your database needs and upgrade" screen. I clicked the 'Upgrade' button, closed the testing window, and restarted tests. This time, they went through 🎉 We should document and/or fix this somewhere, tho 🤔 |
Possibly https://github.com/WordPress/gutenberg/blob/master/docs/contributors/testing-overview.md |
Yes, that's correct.
Thanks, I'll try this out! (update: yep, that fixed it 🎉) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add end-to-end tests for site editor templates export functionality.
How has this been tested?
npm run test:e2eTypes of changes
Code Quality
Checklist: