Mobile: Remove RN CHANGELOGs from npm release automation #28060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Developer Documentation
gziolo
commented
Jan 8, 2021
|
Maybe I should take a different approach and skip processing all packages that are marked as private packages. I will explore it now. |
gziolo
force-pushed
the
update/rn-changelog
branch
from
7debf17 to
831be6c
Compare
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #28042.
Partially improves #28079.
It looks like React Native packages use their own CHANGELOG updates cadence and npm releases cause issues. This PR tries to fix that by skipping CHANGELOG files updates to all private npm packages.
Testing this functionality is very difficult because it uses a repository clone and applies commits to
wp/trunkbranch 😱I applied the following changes to the codebase to print the list of CHANGELOG files that are going to be processed:
It didn't contain private packages anymore.