Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm Packages: Improvements to the publishing process for private packages #28079

Closed
gziolo opened this issue Jan 11, 2021 · 2 comments
Closed

npm Packages: Improvements to the publishing process for private packages #28079

gziolo opened this issue Jan 11, 2021 · 2 comments
Assignees
@gziolo
Labels
npm Packages Related to npm packages

Comments

@gziolo
Copy link
Member

gziolo commented Jan 11, 2021 •
edited
Loading

Description

There is a number of private packages (private set to false in package.json) that get version bumps when publishing new changes with Lerna to npm. They also get CHANGELOG files updated. It creates some friction with the packages maintained by the mobile team that uses its own process and doesn't have immediate plans to publish them to npm.

Proposed solution

We should prevent updates to the version field in package.json and CHANGELOG.md files for WordPress packages that are marked as private.

Related comment in #28042 (comment):

https://www.npmjs.com/package/@lerna/version?activeTab=readme#--no-private

I found something promising - flag that skips private packages when bumping versions. The challenge is that we use lerna publish that uses lerna version internally. I'm sure we can find a way to make it work if that flag is working as I assumed 😃
@gziolo gziolo added the npm Packages Related to npm packages label Jan 11, 2021
@gziolo gziolo changed the title npm Packages: Improvements to the publishing process npm Packages: Improvements to the publishing process for private packages Jan 11, 2021
@gziolo gziolo mentioned this issue Jan 11, 2021
Merged
@gziolo gziolo self-assigned this Jan 11, 2021
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Jan 11, 2021
@gziolo
Copy link
Member Author

gziolo commented Jan 11, 2021 •
edited
Loading

#28060 should address the issue with unwanted updates to CHANGELOG.md files.

@gziolo
Copy link
Member Author

gziolo commented Jan 21, 2021

This issue is now resolved with #28335.

@gziolo gziolo closed this as completed Jan 21, 2021
@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Jan 21, 2021
@dcalhoun dcalhoun mentioned this issue Nov 19, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
npm Packages Related to npm packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gziolo