-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Add navigation panel back button slot #26846
Conversation
In which file should we document the usage? |
Size Change: +9 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
@david-szabo97 Not familiar with it, but the previous slot ( I can see there are some leftovers from the previous implementation in the docs, I guess this is a time as good as any to clean them up and update them to the new version. 🙂 |
packages/edit-site/src/components/navigation-sidebar/navigation-panel/main-back-button.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with and w/o a fill and this works great! 🥳
packages/edit-site/src/components/navigation-sidebar/navigation-panel/main-back-button.js
Outdated
Show resolved
Hide resolved
Updated to reuse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great to see, its much more clean now using the MainDashboardButton
.
Tests good w/ and w/o the fill. 👍 Il ✅ as soon as we get rid of the invalid export noted in my comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine!
I second @Addison-Stavlo request of removing the outdated export (which messes up the build, btw).
As it's a straightforward change, I'll preapprove this.
c42db19
to
1ee3a63
Compare
Description
Create a slot for Navigation Panel Back Button (
< Dashboard
). Enables consumers to replace it with their own component.How has this been tested?
Make sure everything works the same as before.
Test code to test the slot-fill functionality:
Types of changes
New feature
Checklist: