Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon Site Editor: Can't exit the Site Editor #46822

Closed
ianstewart opened this issue Oct 27, 2020 · 5 comments · Fixed by #48231
Closed

Horizon Site Editor: Can't exit the Site Editor #46822

ianstewart opened this issue Oct 27, 2020 · 5 comments · Fixed by #48231
Assignees
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug

Comments

@ianstewart
Copy link
Contributor

I expect this one may turn out to be just a small one to fix as things may have just got a bit out of sync. To reproduce …

Here's what I see when I attempt to exit the Site Editor right now. My browser tab appears to be crashing here in Chrome MacOS.

image

@cathymcbride cathymcbride added Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Type] Bug labels Oct 30, 2020
@ianstewart
Copy link
Contributor Author

Here's a gif …

2020-11-04 15 40 49

@vindl
Copy link
Member

vindl commented Nov 5, 2020

The problem here is that we don't have similar Dotcom specific overrides for this button like we had for W icon. As a result it's attempting to navigate to wp-admin page within the iframe and that request is blocked.

The proper solution here should be:

  • create a slot/fill in core that allows us to replace the default button
  • use that slot to provide a Dotcom specific version of it that navigates back to Calypso dashboard instead of wp-admin

@david-szabo97
Copy link
Contributor

david-szabo97 commented Nov 10, 2020

create a slot/fill in core that allows us to replace the default button

Taking this one 🙂 (WordPress/gutenberg#26846)

@vindl
Copy link
Member

vindl commented Nov 18, 2020

The core PR for this has been merged. Once 9.4 lands on edge sites we can proceed with a Dotcom specific override. One note - since both site editor and post editor use the same slot/fill, we should make sure to limit the fill application to just the site editor context.

@vindl
Copy link
Member

vindl commented Nov 27, 2020

One note - since both site editor and post editor use the same slot/fill, we should make sure to limit the fill application to just the site editor context.

Update: after WordPress/gutenberg#27213 this is no longer true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug
Projects
None yet
5 participants