Core Data: Bring back support for nested _fields values
#25083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +19 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ryelle
commented
Sep 4, 2020
| @@ -76,12 +77,12 @@ function getQueriedItemsUncached( state, query ) { | |||
| // This accounts for the fact that queried items are stored by | |||
| // stable key without an associated fields query. Other requests | |||
| // may have included fewer fields properties. | |||
| const field = fields[ f ]; | |||
| if ( ! item.hasOwnProperty( field ) ) { | |||
| const field = fields[ f ].split( '.' ); | |||
There was a problem hiding this comment.
If this value is left as a string, it matches an undefined value in the state— in my testing I had both meta: { key: 'value' } and 'meta.key': undefined on item, and get matches the string key first, returning undefined. I'm not sure where that other key comes from, but preventing that would be a better fix for this workaround.
Just noting that before #25078 doing this would create subtle bugs where some components could receive "incomplete" entities data. Basically |
|
I tested the PR and it fixed the problem for me 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25078 — The change to
getEntityRecords's use of _fields has broken nested meta field requests. In the API, you can pass nested fields for meta, ex:wp-json/wp/v2/posts?_fields=title,meta.demo,id, and this used to work for the getEntityRecords request.It seems the change in #19498 introduced this:
gutenberg/packages/core-data/src/queried-data/selectors.js
Lines 80 to 82 in 8ba0a42
Which is returning null, because it's testing for
item['meta.key'], rather thanitem.meta.key. This PR switches to using the lodash functionshas,get, andset, which support string keys like that. I've seen some moves away from lodash, but it seems like the most straightforward fix here.How has this been tested?
There's a new test case introduced in
packages/core-data/src/queried-data/test/selectors.jswhich catches this case.You can also test with the code snippet in #25078
Types of changes
Bug fix (non-breaking change which fixes an issue)