Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions in schedule block overlap when viewing from certain locations/timezones #562

Closed
jorgeatorres opened this issue Aug 25, 2020 · 4 comments · Fixed by #696
Closed
Assignees
Labels
[Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Type] Bug

Comments

@jorgeatorres
Copy link

Describe the bug

This might be related to #559. When visiting our WC site from certain locations (for instance, London (UK) or Barcelona (Spain)), some sessions start to overlap making the whole thing unreadable.
These sessions seem to be the ones that fall near the time the day changes (in that timezone), but I'm not sure if that's the real reason.

It is worth mentioning that to work around #559, our site's timezone was changed to UTC (from the previously set "America / Bogota" or UTC-5). I can confirm that the sessions look fine when in UTC-5 or UTC-3, so maybe the the problem only affects UTC+something timezones?

Is there a something we can do from our side besides manually creating a schedule page (not using the block)? Thanks!

To reproduce

Steps to reproduce the behavior:

  1. Set time zone to "Bogotá - Colombia" or "Buenos Aires - Argentina".
    On macOS: Go to System Preferences > Date & Time > Time Zone.
  2. Go to https://colombia.wordcamp.org/2020/agenda/.
  3. Confirm that the whole schedule looks fine.
  4. Change time zone to "London - United Kingdom" (British Summer Time) or "Barcelona - Spain" (Central European Summer Time).
  5. Go to https://colombia.wordcamp.org/2020/agenda/.
  6. See how some session items look wrong, either overlapping or times being displayed over borders. See screenshots below for examples.

Expected behavior

Schedule should look correct in all timezones.

Screenshots

Screen Shot 2020-08-25 at 16 01 26

Screen Shot 2020-08-25 at 18 07 24

WordCamp

https://2020.colombia.wordcamp.org/

System (please complete the following information):

  • Device: Laptop
  • OS: macOS 10.15.6
  • Browser: Chrome
  • Version: 84.0.4147.135
@iandunn iandunn self-assigned this Aug 25, 2020
@iandunn iandunn added [Type] Bug [Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Priority] 1 labels Aug 25, 2020
@iandunn
Copy link
Member

iandunn commented Aug 25, 2020

Note to self: another way to test the time zone is with TZ="Europe/London" open /Applications/FirefoxDeveloperEdition.app in terminal, and verify with Intl.DateTimeFormat().resolvedOptions().timeZone and wp.date.format('P') in browser console. That might avoid unintended side-effects from changing the OS timezone.

@iandunn
Copy link
Member

iandunn commented Aug 27, 2020

Is there a something we can do from our side besides manually creating a schedule page (not using the block)?

I'm hoping to have this fixed soon, but in the mean time you can switch to the block's Single Column Layout style.

@iandunn
Copy link
Member

iandunn commented Sep 7, 2020

@jorgeatorres, it looks like we might need to wait for WordPress/gutenberg#25078 and WordPress/gutenberg#22193 to be fixed & released before we can fix this.

The next Gutenberg released isn't scheduled until after Colombia is over, so I'd recommend switching to the Single Column Layout block style in the meantime. That should prevent the overlap problem.

@iandunn
Copy link
Member

iandunn commented Sep 8, 2020

It looks like the above 2 PRs will solve this, but only when using string timezones 😆 🤷🏻 .

Keeping open until we upgrade to v9 (or possibly later if WordPress/gutenberg#25083 is in a later version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants