Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack: remove TinyMCE external dependency mapping #13971

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

ellatrix
Copy link
Member

Description

This is no longer used. Additionally removes an old irrelevant comment.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 20, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning it up 👍

@gziolo gziolo added this to the 5.2 (Gutenberg) milestone Feb 20, 2019
@@ -48,7 +48,6 @@ const gutenbergPackages = Object.keys( dependencies )
const externals = {
react: 'React',
'react-dom': 'ReactDOM',
tinymce: 'tinymce',
Copy link
Contributor

@youknowriad youknowriad Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we use this in the classic block?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it directly uses the window global.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that's fine for me.

@ellatrix ellatrix merged commit 1a0f88d into master Feb 20, 2019
@ellatrix ellatrix deleted the fix/mce-external-mapping branch February 20, 2019 13:04
@ellatrix
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants