Skip to content

Commit

Permalink
Webpack: remove TinyMCE external dependency mapping (#13971)
Browse files Browse the repository at this point in the history
  • Loading branch information
ellatrix authored Feb 20, 2019
1 parent f43572c commit 1a0f88d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/contributors/coding-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Example:
/**
* External dependencies
*/
import TinyMCE from 'tinymce';
import moment from 'moment';
```

#### WordPress Dependencies
Expand Down Expand Up @@ -142,7 +142,7 @@ const name = 'Matt';

// Bad:
const pet = 'Matt\'s dog';
// Also bad (not using an apostrophe):
// Also bad (not using an apostrophe):
const pet = "Matt's dog";
// Good:
const pet = 'Matt’s dog';
Expand Down
1 change: 0 additions & 1 deletion packages/keycodes/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export const F10 = 121;

export const ALT = 'alt';
export const CTRL = 'ctrl';
// Understood in both Mousetrap and TinyMCE.
export const COMMAND = 'meta';
export const SHIFT = 'shift';

Expand Down
1 change: 0 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ const gutenbergPackages = Object.keys( dependencies )
const externals = {
react: 'React',
'react-dom': 'ReactDOM',
tinymce: 'tinymce',
moment: 'moment',
jquery: 'jQuery',
lodash: 'lodash',
Expand Down

0 comments on commit 1a0f88d

Please sign in to comment.