Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile]Release 0.3.5 updates #13768

Merged
merged 2 commits into from
Feb 8, 2019
Merged

[Mobile]Release 0.3.5 updates #13768

merged 2 commits into from
Feb 8, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 8, 2019 •
edited by hypest
Loading

This PR is for tracking the mobile-gutenberg 0.3.5 release fixes

mobile-gutenberg PR wordpress-mobile/gutenberg-mobile#558

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@pinarol
[Mobile]Remove unnecessary <strong> tags from post title (#13763)
28d1d68 
* Add extra rootTagsToEliminate prop

* Fix lint issues

* Revert unnecessary prop
@pinarol pinarol self-assigned this Feb 8, 2019
@pinarol pinarol requested a review from hypest February 8, 2019 10:40
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 8, 2019
hypest
hypest approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinarol pinarol merged commit 6ee1944 into master Feb 8, 2019
@pinarol pinarol deleted the rnmobile/release_0.3.5 branch February 8, 2019 15:06
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@pinarol @youknowriad
[Mobile]Release 0.3.5 updates (#13768)
697e11c 
* [Mobile]Remove unnecessary <strong> tags from post title (#13763)

* Add extra rootTagsToEliminate prop

* Fix lint issues

* Revert unnecessary prop

* Add code comment for the workaround fix
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@pinarol @youknowriad
[Mobile]Release 0.3.5 updates (#13768)
33a49e8 
* [Mobile]Remove unnecessary <strong> tags from post title (#13763)

* Add extra rootTagsToEliminate prop

* Fix lint issues

* Revert unnecessary prop

* Add code comment for the workaround fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@pinarol pinarol

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@pinarol @hypest @youknowriad @gziolo