[Mobile]Remove unnecessary <strong> tags from post title #13763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinarol
force-pushed
the
rnmobile/remove-strong-from-title
branch
from
c2169aa to
38e68ba
Compare
pinarol
changed the title
etoledom
approved these changes
Feb 8, 2019
pinarol
added a commit
that referenced
this pull request
Feb 8, 2019
* [Mobile]Remove unnecessary <strong> tags from post title (#13763) * Add extra rootTagsToEliminate prop * Fix lint issues * Revert unnecessary prop * Add code comment for the workaround fix
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* [Mobile]Remove unnecessary <strong> tags from post title (#13763) * Add extra rootTagsToEliminate prop * Fix lint issues * Revert unnecessary prop * Add code comment for the workaround fix
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* [Mobile]Remove unnecessary <strong> tags from post title (#13763) * Add extra rootTagsToEliminate prop * Fix lint issues * Revert unnecessary prop * Add code comment for the workaround fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick workaround to remove
<strong>tags from post title. We can see those tags on Aztec editor.How has this been tested?
Tested with steps in gutenberg mobile PR
Implementation Details
Firstly, this is a workaround solution made quickly to catch the WPiOS/WPAndroid release deadline.
The main problem is about the inner mechanisms of Aztec-iOS, and RNTAztec-iOS. whenever there's a bold text it generates the
<strong>elements in the html. [We had made an extra development(https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1127) to prevent such cases for Heading blocks after we made them bold by default, maybe that could help in the future.] Classic editor made this problem visible(maybe because title is a plain UITextView there? ), I think there's sth different there between the Gutenberg/Classic editors and needs further investigation. So this needs a better solution in the future.Checklist: