DotTip: Rename id attribute to tipId

[ramonjd]

Resolves #10305

Description

This PR renames id prop on <DotTip /> to tipId to avoid using common DOM attributes as prop names.

It also removes the eslint exception in the selector, thus reverting it back to its original rule.

How has this been tested?

Manually tested by viewing NUX tips in a new post. Execute localStorage.setItem('WP_DATA_USER_1', '') in the console to remove user data from locale storage if you've already dismissed tips before

I also ran both unit and e2e tests.

npm run lint against changes. Also ran against original props, e.g., <DotTip id="core/editor.publish"> and received the following error: error Do not use string literals for IDs; use withInstanceId instead no-restricted-syntax

Screenshots

Types of changes

This PR renames the id prop to tipId, and correcting related side effects in the tests/snapshots.
We're also updating the documentation to reflect this change, and removing the exception in the eslint selector.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[ramonjd]

Note to reviewer: different e2e tests are failing each time I push. I can't replicate anything consistent locally.

[ajitbohra]

LGTM 👍

[youknowriad]

Should we support id as well in conjunction with a deprecated call?

[youknowriad]

Thanks for the PR @ramonjd I pushed a change add the deprecation, I hope you don't mind :)

[ramonjd]

I pushed a change add the deprecation

No worries @youknowriad ! I had a change ready to commit, but wasn't sure about what to write in the deprecation text or which version was going out next, so I'm glad you got in first :)

I had something like:

// Prop `id` in <DotTip /> is deprecated.
function getIdProp( id ) {
	if ( id ) {
		deprecated( 'Prop `id` in <DotTip />', {
			alternative: 'tipId',
			hint: 'Don\'t use an `id` prop for components that do not require an instanceId',
		} );
	}
	return id;
}

...
	withSelect( ( select, { tipId, id } ) => {
		const dotTipId = tipId || getIdProp( id );
...

Thanks!!

[youknowriad]

Oh sorry, I should have waited, both work though :). Let's wait for the test and merge.