chore: Don't allow string literals in IDs

WordPress · Sep 30, 2018 · 346788c · 346788c
1 parent 0fe7d08
commit 346788c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -152,8 +152,12 @@ module.exports = {
 			},
 			{
 				selector: 'CallExpression[callee.object.name="page"][callee.property.name="waitFor"]',
-				message: 'Prefer page.waitForSelector instead.'
-			}
+				message: 'Prefer page.waitForSelector instead.',
+			},
+			{
+				selector: 'JSXAttribute[name.name="id"][value.type="Literal"]',
+				message: 'Do not use string literals for IDs; use withInstanceId instead.',
+			},
 		],
 	},
 	overrides: [