Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave is not retried after failing once #54969

Open
jsnajdr opened this issue Oct 2, 2023 · 3 comments
Open

Autosave is not retried after failing once #54969

jsnajdr opened this issue Oct 2, 2023 · 3 comments
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended

Comments

@jsnajdr
Copy link
Member

jsnajdr commented Oct 2, 2023

While working on an autosave issue I noticed another one that would be nice to fix:

  1. Start editing an existing post, draft or published.
  2. Change some content so that autosave is requested.
  3. In devtools, change network to Offline before the autosave request is triggered.
  4. The autosave request will fail. Notice "Update failed, you are probably offline" appears.
  5. Go back online.

Expected result is that the editor sooner or later retries the failed autosave, and I don't need to make any extra edits to trigger it.

Actual result is that the autosave is never triggered again until you make further changes. The existing changes don't get autosaved.

@flootr might be interested in looking at this.

@jsnajdr jsnajdr added the [Type] Bug An existing feature does not function as intended label Oct 2, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Oct 2, 2023

I thought apiFetch would retry failed requests automatically, or that's only for expired nonces?

Sidenote: We also want to implement a maxRetries limit. See #42400.

@Mamaduka Mamaduka added the [Feature] Saving Related to saving functionality label Oct 2, 2023
@tyxla
Copy link
Member

tyxla commented Oct 2, 2023

I wonder if #13509 is still valid. If it is, it could be one of the potential reasons for save failures and we should likely handle it in a better way.

@Mamaduka
Copy link
Member

Mamaduka commented Oct 2, 2023

@tyxla, yes, that's still a valid issue. Here are my detailed findings - #13509 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants