Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More conservative number of retry attempts for failed requests #42400

Open
desrosj opened this issue Jul 13, 2022 · 1 comment · May be fixed by #32475
Open

More conservative number of retry attempts for failed requests #42400

desrosj opened this issue Jul 13, 2022 · 1 comment · May be fixed by #32475
Labels
REST API Interaction Related to REST API [Type] Enhancement A suggestion for improvement.

Comments

@desrosj
Copy link
Contributor

desrosj commented Jul 13, 2022

Description

While testing to see if Core-13779 was still happening in WordPress 6.0, I found that it was, and actually causes potentially greater problems in the block editor.

TLDR of that ticket: When the WordPress files are in a directory and a site is set up to run as such (site.com/wp) and the site is changed to instead be visible from the site's root (site.com), all users who are logged in will not be properly authenticated. This is because the cookie set on login does not exist for the new location.

In the past, this caused issues with the Classic Editor and previewing posts. However, in WordPress 6.0, if you open the block editor, there are repeated requests to the REST API that return 403 responses. After opening the editor with my browser console open, ~500 requests were made in 30 seconds.

Regardless of the root cause of the 403 responses, the editor should not continually retry the same requests infinitely.

Step-by-step reproduction instructions

  1. Create a WordPress install in a subdirectory (/wp for example).
  2. Log in, and follow steps 2-9 found here.
  3. Open the browser's console and click the network tab.
  4. Create a new post or edit an old one.
  5. Observe the repeated requests.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka
Copy link
Member

Probably related to #13509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REST API Interaction Related to REST API [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants