-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving multi-entity saving UI method. #31456
Comments
Additional mockups. If the title/name of an object is long then it can wrap. Another option would be to use the 3 dot (ellipsis) drop down. It looks like the ellipsis menu will give us some additional space in this area. |
The ellipsis makes sense to me as these will be secondary actions in most cases. I do question the need for the save action though. Isn't the duplicative of the big blue "Save" button at the top? |
Yeah, the "Select" affordance can potentially go in there as well. |
Clicking "Select" selects the object in the Canvas. One should also be able to click the title and automatically have it selected in the canvas area. I am also creating a mockup removing the checkboxes, so that the user can really decide to click the 3 dots and select discard. Removing the object from the Save panel. |
Here is a prototype. FSE-discard-save.mp4Link to the prototype figma file: |
One drawback to this flow: Let's say I've edited my header and my footer. I want to save the changes to the header immediately. I also want to keep the changes to my footer and continue working on it. With the removal of the checkboxes that is no longer possible. I suppose the "Save changes" menu item in the ellipsis can help, but does that feel a bit awkward? 🤔 An inline save (like the one from Reusable Blocks) might be better. |
Good point. I am bringing back the checkboxes. Taking this adjustment one step at a time. FSE-discard-save.mp4 |
Since discarding is a destructive action, did you think about how we might protect the user from removing their changes mistakenly? Lots of existing tools to consider in that regard:
Discarding feels similar to the "Clear customizations" flow in the site editor, so we can probably align with that. |
As discarding requires the user to first click the ellipsis menu and then selecting Discard. There are two steps required to make before a discard can be done.
The undo button located in the top left of the screen could as you say also work for discards. As it seems like the easiest method.
It can be done, but it requires an extra click for a user to discard an object.
I think we need to look at the general guidelines for how snackbar confirmations are used. I am hesitant going both ways on this one.
Two things we can add.
I am not sure what you mean with this. |
That makes sense to me 👍 Checkboxes and Discard together enable all possible usecases of saving or not saving, and I would show a snackbar with revert/undo action after a Discard. Having to first click through a warning modal of some kind would get annoying after a while I reckon. |
It could be something like this:
Multi-entity-flow-with-snackbar-notification.mp4 |
I would change the language in the Snackbar a bit. It should be confirmatory rather than ask a question. So instead of:
Something like:
This would be consistent with other Snackbards offering an undo affordance. |
Adjusted the Snackbar language. Multi-entity-flow-with-snackbar.mp4Link to prototype: |
I'd like to offer a prototype I worked on in the context of another issue some weeks ago: FSE: Allow the ability to Save Draft and Schedule changes My prototype touches many of the functionalities listed in this discussion and adds a couple of extra things:
I do think offering the ability to save or discard changes at this stage could be useful and since the user is dealing with reverting or making changes permanent. Here's a short version of the video from the other issue: save.mov |
Very interesting! I like a lot of this. One part I'm not sure about is the "Undo last change" button in the save panel. I would expect the regular undo button to still work in this context, and we have the undo affordance in the snackbar, so do we need the extra undo button here? I think I mentioned this elsewhere, but I'm also on the fence about allowing "Reset to initial state" here. It may just be the ambiguity of the language though... I can see it being interpreted both as a "Discard changes" and a "Reset to factory settings" which are very different actions. Maybe it just needs a description like the "Clear customizations" action in the site editor: |
I hadn't noticed that the undo & redo buttons affect the changes made to the sidebar items, so I think you are right, and we don't need that new button. And I also agree with you about the need to make the labels for those destructive actions more clear & distinctive (either through a change of text or with a description) |
Loving these explorations so far and can see this working really nicely in tandem with the Save button in the toolbar that's being looking into for Reusable blocks: #29871 (comment) There were some earlier explorations around adding the Discard functionality into the block inspector within that issue, but I think incorporating it into the multi-entity saving flow that's being worked on here makes a lot more sense 😁 |
It feels like for version 0.1 PR we will add the "Select" and "Discard" option into the ellipsis drop down menu. Then for later iterations/versions one can look into extending the ellipsis drop down, as well as other things. |
I find "Select" a little confusing. Even currently, when it's just checkbox and "Select" button, it took me a few minutes to realize what button was selecting. Pairing it with the "Discard" button might make things a little confusing IMO. I like @javierarce's mockup where labels are more descriptive. |
We could of course chance "Select" and "Discard" to add a little more description such as "Select template" (Reusable block/Etc) and "Discard changes". It gives a bit more clarity to what the options are. |
That's a great idea. Here's a variation of that second screen. I've simplified the interface by removing the discard links. Adding a little bit of friction through the checkboxes will probably make more sense, because of the destructive nature of the action. Discard.and.save.movI've updated the Figma file with that prototype. |
@javierarce - Great iterations. I feel like the overall flow is feeling good now. Something I keep coming back to is the overall IA of this panel - how the info is organized and presented to the user and what information we surface. A couple questions that come to mind:
|
Isn't that what the Related to this and @javierarce 's great exploration:
|
In theory, perhaps. In practice, its not obvious and I think we could look at generally updating the IA here. |
Good call, @kellychoffman . Anything that can clarify what changes will affect other instances/places is extra helpful here! |
@kellychoffman @priethor I think we could definitely improve the IA of the sidebar by moving the items whose changes have a bigger impact to the top. I don't know why I put the template parts at the bottom, but a better arrangement could be: If we also improve the labelling of both the items and each section, users will understand the impact of their changes. Here's a new version of the sidebar with the changes I mentioned.
I think so. I'm not sure if there are other groups we could use to organize the changes.
+1. I think placing the global changes at the top will make that distinction more clear.
Yes, you can also have
That makes a lot of sense.
That's interesting @priethor… what kind of changes were you thinking of? I think it would be great if we could show more granular information about the changes to the user. |
Just the ones you added in this iteration, including the individual blocks/items (logo, title, tagline) 😄 Because the previous iteration showed |
Going to lock this issue as a design in that is ready for dev. "Locking" is for dev clarity and is not meant to dissuade further design contribution - open new issues or unlock if needed!
|
👋 I'll give this a stab! |
PR for the first part (add entity descriptions, re-order entities, change panel header copy): #35933 |
I think let's kick this out from WP 5.9 as #36185 is blocked and we are past the feature freeze date. |
PR for the second part ("Discard changes" panel): #36185 |
Could anyone give somekind of status update on this feature? |
It hasn't shifted since originally introduced. There is an additional save option built into the new dark grey sidebar in the site editor when you've edited multiple items in 6.2 that reuses the same experience. |
There's a new issue that explore updating designs to the multi-entity flows here #49832 I think we should consider closing this one to avoid duplication and centralize efforts. |
Various feedback on multi-entity saving method have become spread into various issues that talk about different aspects of multi-entity saving.
The current multi-entity saving method.
Clicking the Save button leads to the Save panel.
1- Here one can uncheck various options. For instance if I uncheck the header. (H should be capitalized.)
2- Then click Save.
3- Make some changes in the canvas/layout area.
4- Click Save again. The header is still seen. Along with anything else that has been adjusted.
Improving the Saving flow.
One idea is to add a discard option like so:
Added by @jameskoster in this isse (comment): Refine save flow when editing template and publishing content https://github.com//issues/30800#issuecomment-829990021
--
Another option is where I removed the checkboxes, added Discard options and instead added an inline Save (so one can save each individual item or click the Save button in the top to save all).
One suggestion without the additional Save option.
Associated issues:
Refine save flow when editing template and publishing content
#30800
Show save button in the Reusable Block toolbar if there are changes
#29871
Page Template: Not able to cancel save of page template.
#31043
The text was updated successfully, but these errors were encountered: