Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Template: Not able to cancel save of page template. #31043

Closed
paaljoachim opened this issue Apr 21, 2021 · 4 comments
Closed

Page Template: Not able to cancel save of page template. #31043

paaljoachim opened this issue Apr 21, 2021 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 21, 2021

I am going through the process of creating an user interface for the new page template feature.
One thing that bugs me over and over is that I am not able to cancel the save of a template/reusable block etc etc.

It should be as simple as unchecking an option to not save it. Having it automatically revert back to nothing or to the last save.

Here is the Page template save process at the moment. It starts out inside the Page template area.

Can-not-cancel-save-of-template.mp4

Possible solution:
Uncheck options to move onward to publish.

@paaljoachim paaljoachim added [Feature] Full Site Editing [Type] Bug An existing feature does not function as intended labels Apr 21, 2021
@paaljoachim paaljoachim changed the title Not able to cancel save of template. Not able to cancel save of page template. Apr 22, 2021
@paaljoachim paaljoachim changed the title Not able to cancel save of page template. Page Template: Not able to cancel save of page template. Apr 22, 2021
@paaljoachim paaljoachim added the [Type] Enhancement A suggestion for improvement. label Apr 22, 2021
@paaljoachim
Copy link
Contributor Author

A simple solution would be to uncheck what one does not want to save.
An example. Discarding to save a page template would bring one back to the Pages screen with use of the default page template. As discarding to save a page template would also delete the page template one initially created but decided later on not to save.

Discard-save-of-Page-template.mp4

@jameskoster
Copy link
Contributor

I think we can potentially close this one since #30793 is merged :) In the video below I demonstrate editing a post and a template in the same session, but only saving the changes to the post:

no-template-save.mp4

To discard the template changes you simply exit the editor.

It may be worth exploring a dedicated "Discard" action that could be applied to any entity in the multi-entity save flow, maybe something like:

Screenshot 2021-04-22 at 17 46 08

But really that's not doing much different to just un-checking the checkbox.

@paaljoachim
Copy link
Contributor Author

That is the best Discard suggestion I have seen. Discard text link seen beside each item that is to be saved.
Simple and straight forward approach. This can also be used for Reusable blocks. @critterverse
#29871

(Users might uncheck first and then click the Discard link.)

One more thing Discarding also needs to result having the Publish dot removed, as it needs to know that specific items will not be saved and are discarded.

@annezazu
Copy link
Contributor

Going to go ahead and close this out considering this seems to be covered in the issue Jay mentioned above. Further, this issue relates to what's described here as the changes should be disregarded when switching between modes: #27896 Love seeing the creativity here in how to tackle this thorny problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants