Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page template: Overview/enhancements #31097

Closed
paaljoachim opened this issue Apr 22, 2021 · 1 comment
Closed

Page template: Overview/enhancements #31097

paaljoachim opened this issue Apr 22, 2021 · 1 comment
Labels
[Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 22, 2021

I am first adding this overview of Page Templates in relation to the current bare bones approach and how it can be improved.

The Page.

In the right sidebar we see a new Template panel.
New

Page-screen

We need to add the Page name into the top bar in this issue, as that will also help with the Page template. #27093 (comment)

--

Clicking New:
Brings up a modal. The modal title says "Create a custom template". It will be better to give it a clear name to where it is to be used. Page template: Rename "Create a custom template" to "Create a page template" Create template.
#31086


Page template: Adjust snackbar notification text.
#31087


Template parts. When entering the page template we will see the Site title and tagline. It should be added into a Header template block. Content, footer and other sidebars should also be added into their own template blocks.
Page template: Show template parts
#31090


Changing the word button word "Apply" to "Save".
#31091
(Closed as not relevant any longer.)


Being able to cancel saving the template. User creates a page template and decides not to save it. Upon discarding a save the page template is also deleted.
#31043

Suggestion to discard a save from James:
#31043 (comment)


Saving a page template.
Goes back to post content. Various features seen in one issue:
Template part wrapper.
Movie template sidebar item clickable.
Page Attributes drop down. Correct template seen.
#31096


The prototype:
https://www.figma.com/proto/ilcZuJZd872FkTvbJwxccL/Page-Templates?node-id=1%3A6&scaling=min-zoom&page-id=1%3A5

A walk through video:
https://youtu.be/8AEy6qNfWZU

First version of Page templates that were included into the Gutenberg plugin: #30438

@paaljoachim paaljoachim added [Feature] Full Site Editing [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Apr 22, 2021
@paaljoachim
Copy link
Contributor Author

Closing issue as most features have been dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

1 participant