Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page template: Show template parts #31090

Closed
paaljoachim opened this issue Apr 22, 2021 · 15 comments
Closed

Page template: Show template parts #31090

paaljoachim opened this issue Apr 22, 2021 · 15 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 22, 2021

Entering the Template mode one will see the Site title and the tagline.
It would be helpful to add the Header, Content, Footer and other sidebars into template part blocks.

Going from (mockup from: #31087 )
Entering-page-template

To:

Page-template-template-parts.mp4
@jameskoster
Copy link
Contributor

I can't find the PR now, but I recall suggesting that we spawn new Header and Footer template parts in this flow if they do not already exist.

@youknowriad had some good feedback as to why that was not a good idea, but since I can't find the PR, I can't remember what his points were 😅

@youknowriad
Copy link
Contributor

My main point is that we might want to ship the template mode before actually shipping template parts in Core. That said, it's still a good idea to rely on the semantic "header" and "footer" template parts if they exist for a theme instead of creating random ones. So it would be a good follow-up to do at some point.

@paaljoachim
Copy link
Contributor Author

Ahhh....
Ship the template mode first.
Then later add template parts.

So the first version we are focusing on being able to edit the full page - header, content and footer etc are mixed into one. I do wonder if there should be included some nuance between the various areas..... or maybe not...

@jameskoster
Copy link
Contributor

My main point is that we might want to ship the template mode before actually shipping template parts in Core.

But if a block theme is active, you'll get access to template part editing as soon as you engage the template editor. I'm not sure I quite understand the concept of shipping template mode without template parts 🤔

That said, it's still a good idea to rely on the semantic "header" and "footer" template parts if they exist for a theme instead of creating random ones. So it would be a good follow-up to do at some point.

Agreed, we should check if the parts exist in this flow, and include them if they do.

@youknowriad
Copy link
Contributor

But if a block theme is active, you'll get access to template part editing as soon as you engage the template editor. I'm not sure I quite understand the concept of shipping template mode without template parts

Block themes are not being shipped in 5.8. Template mode for classic themes is considered.

@carolinan
Copy link
Contributor

Please clarify this. It won't be possible to activate a theme like TT1 Blocks without Gutenberg in 5.8?

@carolinan
Copy link
Contributor

Please understand that this type of information is crucial and greatly affects how contributors choose to spend their time.
For example, how the WordPress.org themes team, and the meta team to some extent, allocates volunteer time to make sure that block themes can be uploaded to the theme directory.

@youknowriad
Copy link
Contributor

youknowriad commented Apr 26, 2021

Please clarify this. It won't be possible to activate a theme like TT1 Blocks without Gutenberg in 5.8?

Yes, that's my understanding, I see no mention of block themes in https://make.wordpress.org/core/2021/04/20/full-site-editing-go-no-go-next-steps/ (I mean anything aside theme.json)

@paaljoachim
Copy link
Contributor Author

Should I go ahead and close this issue?
I am circling back into some of my older issues trying to figure out if I should close them or leave them open and ask for somekind of status update.

@jameskoster
Copy link
Contributor

Thanks @paaljoachim. I'm trying to remember when this occurs, is it when you have a non-block theme active and engage the template editor in the post editor?

Instead of just displaying the site title / tagline, it might now make sense to insert an empty Header template part. That would expose the 'Choose' UI where folks can select a header from contextual patterns:

Screenshot 2023-04-04 at 10 00 06

@paaljoachim
Copy link
Contributor Author

Hey James @jameskoster

I have a feeling what I am talking about is different compared to what was discussed in this issue...

Retesting.
Using Twenty Twenty Three.
WordPress 6.2
Gutenberg plugin 15.4

The Site Editor

The current page template shows a header, Post Featured Image, Post Title, Post Content, Comments and a Footer.

Entering a template it would be easier to have 3 main template parts as the header, content (Post Featured Image, Post Title, Post Content, Comments) and the footer. It would give a clarity to how the template is put together. How it is made by the 3 template parts.

Header
Content
Footer

In Page template

Editing the current Page template inside a page.
The difficult part here is that it looks different from editing a template in the site editor. It should have a smooth transition between in page template editing and the Site Editor editing template experience.

The in page template editing also has the template split up into many parts. It would be helpful to have the main template parts be Header, Content and Footer.

@jameskoster
Copy link
Contributor

I'm not 100% certain, but what you're describing sounds similar to what's being explored in #49292.

It feels like we're approaching a point where the post and site editors will converge, which would be preferable, rather than attempting to keep two separate editors 'in sync'.

@paaljoachim
Copy link
Contributor Author

Yeah it is fairly similar to the issue you mentioned.
Should I close this issue?

@jameskoster
Copy link
Contributor

Up to you 👍

@paaljoachim
Copy link
Contributor Author

We can always circle back to this if needed again at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants