-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page template: Show template parts #31090
Comments
I can't find the PR now, but I recall suggesting that we spawn new Header and Footer template parts in this flow if they do not already exist. @youknowriad had some good feedback as to why that was not a good idea, but since I can't find the PR, I can't remember what his points were 😅 |
My main point is that we might want to ship the template mode before actually shipping template parts in Core. That said, it's still a good idea to rely on the semantic "header" and "footer" template parts if they exist for a theme instead of creating random ones. So it would be a good follow-up to do at some point. |
Ahhh.... So the first version we are focusing on being able to edit the full page - header, content and footer etc are mixed into one. I do wonder if there should be included some nuance between the various areas..... or maybe not... |
But if a block theme is active, you'll get access to template part editing as soon as you engage the template editor. I'm not sure I quite understand the concept of shipping template mode without template parts 🤔
Agreed, we should check if the parts exist in this flow, and include them if they do. |
Block themes are not being shipped in 5.8. Template mode for classic themes is considered. |
Please clarify this. It won't be possible to activate a theme like TT1 Blocks without Gutenberg in 5.8? |
Please understand that this type of information is crucial and greatly affects how contributors choose to spend their time. |
Yes, that's my understanding, I see no mention of block themes in https://make.wordpress.org/core/2021/04/20/full-site-editing-go-no-go-next-steps/ (I mean anything aside theme.json) |
Should I go ahead and close this issue? |
Thanks @paaljoachim. I'm trying to remember when this occurs, is it when you have a non-block theme active and engage the template editor in the post editor? Instead of just displaying the site title / tagline, it might now make sense to insert an empty Header template part. That would expose the 'Choose' UI where folks can select a header from contextual patterns: |
Hey James @jameskoster I have a feeling what I am talking about is different compared to what was discussed in this issue... Retesting. The Site EditorThe current page template shows a header, Post Featured Image, Post Title, Post Content, Comments and a Footer. Entering a template it would be easier to have 3 main template parts as the header, content (Post Featured Image, Post Title, Post Content, Comments) and the footer. It would give a clarity to how the template is put together. How it is made by the 3 template parts. Header In Page templateEditing the current Page template inside a page. The in page template editing also has the template split up into many parts. It would be helpful to have the main template parts be Header, Content and Footer. |
I'm not 100% certain, but what you're describing sounds similar to what's being explored in #49292. It feels like we're approaching a point where the post and site editors will converge, which would be preferable, rather than attempting to keep two separate editors 'in sync'. |
Yeah it is fairly similar to the issue you mentioned. |
Up to you 👍 |
We can always circle back to this if needed again at a later time. |
Entering the Template mode one will see the Site title and the tagline.
It would be helpful to add the Header, Content, Footer and other sidebars into template part blocks.
Going from (mockup from: #31087 )
To:
Page-template-template-parts.mp4
The text was updated successfully, but these errors were encountered: