[RNMobile]: Remove the cancel button from settings options #29599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effects Android only. Removes the cancel button from the settings options (SelectControl)
AmandaRiu
added
[Feature] Block settings menu
|
Size Change: +19 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Merged
2 tasks
antonis
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Nice work @AmandaRiu 👍
Tested this on a Pixel 2 XL (Android 11) and the Cancel button is removed from all five blocks.
The code changes are consistent and LGTM 🎉
|
Thanks for the review @antonis! |
This was referenced Mar 12, 2021
2 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#3222. This effects Android only. Removes the cancel button from the settings options (SelectControl). This PR affects the following blocks:
Gutenberg Mobile PR
wordpress-mobile/gutenberg-mobile#3229
How has this been tested?
Change only effects Android:
Screenshots
Audio Block
File Block
Latest Posts Block
Video Block
Gallery Block
Types of changes
Non-breaking change
Checklist: