Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove Cancel button in bottom sheets #3222

Closed
kyleaparker opened this issue Mar 5, 2021 · 1 comment · Fixed by WordPress/gutenberg#29599 or #3229
Closed

[Android] Remove Cancel button in bottom sheets #3222

kyleaparker opened this issue Mar 5, 2021 · 1 comment · Fixed by WordPress/gutenberg#29599 or #3229
Assignees
@AmandaRiu
Labels
HACK 3/2021 HACK week March 2021 [Type] Task

Comments

@kyleaparker
Copy link

I came across several places where we're showing a "Cancel" button in popups from the bottom sheet on Android. @iamthomasbishop had mentioned that this shouldn't be the case.

The blocks include (from left to right): Video, Gallery, Latest Posts, and File
Screen Shot 2021-03-05 at 10 12 27 AM
@AmandaRiu AmandaRiu self-assigned this Mar 5, 2021
@AmandaRiu
Copy link
Contributor

I'll take this one. Need something small to give my brain a little break from troubleshooting more complex code.

@AmandaRiu AmandaRiu mentioned this issue Mar 6, 2021
Merged
7 tasks
@AmandaRiu AmandaRiu mentioned this issue Mar 8, 2021
Merged
2 tasks
@AmandaRiu AmandaRiu added the HACK 3/2021 HACK week March 2021 label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmandaRiu AmandaRiu

Labels
HACK 3/2021 HACK week March 2021 [Type] Task
Projects
None yet
Milestone
No milestone
3 participants
@kyleaparker @hypest @AmandaRiu