-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.50.0 #3324
Release 1.50.0 #3324
Conversation
# Conflicts: # gutenberg
…n-position Search Block 4: Implement button position UI
For the task Re-running since this PR exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tested the demo app, WPAndroid, and WPiOS and didn't see any issues.
I looked into the merge conflict a little, and it looks like that is occurring because the PR merging trunk
into develop
for 1.49.0 squashed the commits after resolving the conflicts, so now the conflicts are reappearing since GitHub doesn't realize they were already resolved. In other words, the presence of conflicts in this PR doesn't seem to indicate that anything is wrong.
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. LGTM 🚢
Android (Test Suite 2) 🟡
DarkMode - 1
Group - 1
Spacer - 1
Buttons-1
Buttons-2
Buttons-3
Button-6
Color Settings - 1
Image - 1
Story block - 1
❌ Story block - Add media to non-empty Story blockWhen trying to edit an non-empty story block I found some issues:
Screenrecorder-2021-04-07-14-34-19-438.mp4 |
Writing Flow - AndroidI tested the writing Flow cases on version 17.1-rc-1 of the WordPress Android release. Writing Flow checklistGeneral
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
|
Writing Flow - iOSTesting Writing Flow cases on 17.1 (17.1.0.0) beta from Test Flight: Writing Flow checklistGeneral
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
|
Hey @mzorz 👋 while doing some sanity tests for the Story block on Android I encountered an issue and I was wondering if this is known, if it's something new or just specific to the device I used. Can you please take a look at the issue I described here #3324 (comment) I added a video at the end of the comment. Thanks! |
Update: ❌ Story block - Add media to non-empty Story block
This one is being investigated.
There's an open issue for this one already. Buttons block - Buttons alignment options - TC007
A PR was opened to disable this new alignment but this won't be a blocker since it's not a new regression for this release. |
Update: ❌ Story block - Add media to non-empty Story blockIt is not a blocker for the Gutenberg mobile release, an issue was opened to fix it that and will be included either in WordPress-Android or stories-android. With that, there aren't any blockers from Android (Test Suite 2). |
Release for Gutenberg Mobile 1.50.0
Related PRs
Extra PRs that Landed After the Release Was Cut
Changes
Test plan
Release Submission Checklist
RELEASE-NOTES.txt
andgutenberg/packages/react-native-editor/CHANGELOG.md
are updated with all the changes that made it to the release.